Banjofox/doc rework #268
Merged
Banjofox/doc rework #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasguyett
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Can you remove any non-document related commits from this branch? Specifically, I'd prefer we remove any of the workflow changes and save those for a different PR.
I found one broken link, but the rest of the project relative links seem to be fine.
Overall, a very good and very appreciated improvement!
BanjoFox
force-pushed
the
banjofox/doc-rework
branch
from
91c8a2d
to
fb49e03
Compare
* Update rust.yml * Update rust.yml - more changes * Update rust.yml - syntax fix * Update rust.yml * Found travis -> Actions converter * Re-add travis-conversion.yml * Remove rust workflow yml * Fix travis-conversion yml syntax * Add giant block for rust-build from ATiltedTree * Syntax fix * Trying to add openSSL * Adding a Clippy check x-X * Lets try adding a toolchain... * Adding separate toolchain file * Small branch to clean up merge artifacts in documentation. * Trying out new clippy action Swapping lint job https://github.com/marketplace/actions/rust-clippy-check * Splitting clippy lint into its own file. * Did rust-clippy.yml get added? * updating branch list for rust-clippy.yml * Reverting travis-conversion.yml name change because we can disable it in Git Hub UI * Adding Rust-Clippy badge to README.md
BanjoFox
force-pushed
the
banjofox/doc-rework
branch
from
fb49e03
to
d05671b
Compare
Co-authored-by: Nicholas Guyett <nicholas@guyett.me>
BanjoFox
force-pushed
the
banjofox/doc-rework
branch
from
d05671b
to
e23f19d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapsing a LOT of documentation into smaller list of files.