Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cohortdefiners return validatedframes #711

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

sarakolding
Copy link
Contributor

Automatically created PR from invoke

@sarakolding sarakolding linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link
Contributor

Looks like your PR modifies shared library files in psycop/common/.

We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-)

@sarakolding
Copy link
Contributor Author

@MartinBernstorff what I think is happening is that the PredictionTimeCollator (in seq models) is no longer runtime_checkable since it contains CohortDefiner, and CohortDefiner now uses the ValidatedFrame which is not runtime_checkable. But I'm pretty lost (and Lasse is too), so maybe we can talk about it tomorrow 🐒

@sarakolding
Copy link
Contributor Author

(ps it is not done - I can't run the tests because of the error)

Copy link
Contributor

Sure thing. I'm here today; I'll wait until we can talk 👍

@sarakolding
Copy link
Contributor Author

thoughts: more cols/validators? e.g., uuid col with a unique rule?
also, maybe we should make a getattribute method or something, so the frame can be called from the instance, instead of the attribute?

psycop/common/cohort_definition.py Outdated Show resolved Hide resolved
psycop/common/cohort_definition.py Outdated Show resolved Hide resolved
psycop/common/cohort_definition.py Outdated Show resolved Hide resolved
psycop/common/cohort_definition.py Outdated Show resolved Hide resolved
psycop/common/cohort_definition.py Outdated Show resolved Hide resolved
psycop/common/test_cohort_definition.py Outdated Show resolved Hide resolved
@sarakolding sarakolding merged commit 978e84d into main Jan 17, 2024
5 checks passed
@sarakolding sarakolding deleted the 659-feat-cohortdefiners-return-validatedframes branch January 17, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: cohortdefiners return validatedframes
2 participants