-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cohortdefiners return validatedframes #711
feat: cohortdefiners return validatedframes #711
Conversation
Looks like your PR modifies shared library files in We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-) |
@MartinBernstorff what I think is happening is that the PredictionTimeCollator (in seq models) is no longer runtime_checkable since it contains CohortDefiner, and CohortDefiner now uses the ValidatedFrame which is not runtime_checkable. But I'm pretty lost (and Lasse is too), so maybe we can talk about it tomorrow 🐒 |
(ps it is not done - I can't run the tests because of the error) |
Sure thing. I'm here today; I'll wait until we can talk 👍 |
thoughts: more cols/validators? e.g., uuid col with a unique rule? |
Automatically created PR from invoke