From 667afa8314cfa1c50321c0ffc17824569f81de15 Mon Sep 17 00:00:00 2001 From: Mark Rossetti Date: Thu, 20 Feb 2020 15:24:35 -0800 Subject: [PATCH] feat: update pause image to 1.3.0 (includes 1903 and 1909 support) (#2757) --- parts/k8s/windowskubeletfunc.ps1 | 30 +++++++++++----------------- pkg/engine/templates_generated.go | 28 ++++++++++---------------- vhd/packer/configure-windows-vhd.ps1 | 2 +- 3 files changed, 24 insertions(+), 36 deletions(-) diff --git a/parts/k8s/windowskubeletfunc.ps1 b/parts/k8s/windowskubeletfunc.ps1 index d1cd257cb8..c0b7eb1ac0 100644 --- a/parts/k8s/windowskubeletfunc.ps1 +++ b/parts/k8s/windowskubeletfunc.ps1 @@ -159,25 +159,19 @@ New-InfraContainer { # Reference for these tags: curl -L https://mcr.microsoft.com/v2/k8s/core/pause/tags/list # Then docker run --rm mplatform/manifest-tool inspect mcr.microsoft.com/k8s/core/pause: - $defaultPauseImage = "mcr.microsoft.com/k8s/core/pause:1.2.0" - - switch ($computerInfo.WindowsVersion) { - "1803" { - $imageList = docker images $defaultPauseImage --format "{{.Repository}}:{{.Tag}}" - if (-not $imageList) { - Invoke-Executable -Executable "docker" -ArgList @("pull", "$defaultPauseImage") -Retries 5 -RetryDelaySeconds 30 - } - Invoke-Executable -Executable "docker" -ArgList @("tag", "$defaultPauseImage", "$DestinationTag") - } - "1809" { - $imageList = docker images $defaultPauseImage --format "{{.Repository}}:{{.Tag}}" - if (-not $imageList) { - Invoke-Executable -Executable "docker" -ArgList @("pull", "$defaultPauseImage") -Retries 5 -RetryDelaySeconds 30 - } - Invoke-Executable -Executable "docker" -ArgList @("tag", "$defaultPauseImage", "$DestinationTag") + $defaultPauseImage = "mcr.microsoft.com/oss/kubernetes/pause:1.3.0" + + $pauseImageVersions = @("1803", "1809", "1903", "1909") + + if ($pauseImageVersions -icontains $computerInfo.WindowsVersion) { + $imageList = docker images $defaultPauseImage --format "{{.Repository}}:{{.Tag}}" + if (-not $imageList) { + Invoke-Executable -Executable "docker" -ArgList @("pull", "$defaultPauseImage") -Retries 5 -RetryDelaySeconds 30 } - "1903" { Build-PauseContainer -WindowsBase "mcr.microsoft.com/windows/nanoserver:1903" -DestinationTag $DestinationTag} - default { Build-PauseContainer -WindowsBase "mcr.microsoft.com/nanoserver-insider" -DestinationTag $DestinationTag} + Invoke-Executable -Executable "docker" -ArgList @("tag", "$defaultPauseImage", "$DestinationTag") + } + else { + Build-PauseContainer -WindowsBase "mcr.microsoft.com/nanoserver-insider" -DestinationTag $DestinationTag } } diff --git a/pkg/engine/templates_generated.go b/pkg/engine/templates_generated.go index 8140daba54..2509c346ea 100644 --- a/pkg/engine/templates_generated.go +++ b/pkg/engine/templates_generated.go @@ -42898,25 +42898,19 @@ New-InfraContainer { # Reference for these tags: curl -L https://mcr.microsoft.com/v2/k8s/core/pause/tags/list # Then docker run --rm mplatform/manifest-tool inspect mcr.microsoft.com/k8s/core/pause: - $defaultPauseImage = "mcr.microsoft.com/k8s/core/pause:1.2.0" + $defaultPauseImage = "mcr.microsoft.com/oss/kubernetes/pause:1.3.0" - switch ($computerInfo.WindowsVersion) { - "1803" { - $imageList = docker images $defaultPauseImage --format "{{.Repository}}:{{.Tag}}" - if (-not $imageList) { - Invoke-Executable -Executable "docker" -ArgList @("pull", "$defaultPauseImage") -Retries 5 -RetryDelaySeconds 30 - } - Invoke-Executable -Executable "docker" -ArgList @("tag", "$defaultPauseImage", "$DestinationTag") - } - "1809" { - $imageList = docker images $defaultPauseImage --format "{{.Repository}}:{{.Tag}}" - if (-not $imageList) { - Invoke-Executable -Executable "docker" -ArgList @("pull", "$defaultPauseImage") -Retries 5 -RetryDelaySeconds 30 - } - Invoke-Executable -Executable "docker" -ArgList @("tag", "$defaultPauseImage", "$DestinationTag") + $pauseImageVersions = @("1803", "1809", "1903", "1909") + + if ($pauseImageVersions -icontains $computerInfo.WindowsVersion) { + $imageList = docker images $defaultPauseImage --format "{{.Repository}}:{{.Tag}}" + if (-not $imageList) { + Invoke-Executable -Executable "docker" -ArgList @("pull", "$defaultPauseImage") -Retries 5 -RetryDelaySeconds 30 } - "1903" { Build-PauseContainer -WindowsBase "mcr.microsoft.com/windows/nanoserver:1903" -DestinationTag $DestinationTag} - default { Build-PauseContainer -WindowsBase "mcr.microsoft.com/nanoserver-insider" -DestinationTag $DestinationTag} + Invoke-Executable -Executable "docker" -ArgList @("tag", "$defaultPauseImage", "$DestinationTag") + } + else { + Build-PauseContainer -WindowsBase "mcr.microsoft.com/nanoserver-insider" -DestinationTag $DestinationTag } } diff --git a/vhd/packer/configure-windows-vhd.ps1 b/vhd/packer/configure-windows-vhd.ps1 index 53dcb86c70..840ae393d7 100644 --- a/vhd/packer/configure-windows-vhd.ps1 +++ b/vhd/packer/configure-windows-vhd.ps1 @@ -42,7 +42,7 @@ function Get-ContainerImages $imagesToPull = @( "mcr.microsoft.com/windows/servercore:ltsc2019", "mcr.microsoft.com/windows/nanoserver:1809", - "mcr.microsoft.com/k8s/core/pause:1.2.0") + "mcr.microsoft.com/oss/kubernetes/pause:1.3.0") foreach ($image in $imagesToPull) { docker pull $image