Extract common logic to abstract class, replace deprecated client met… #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerveada
reviewed
Dec 22, 2021
| import java.util | ||
|
|
||
|
|
||
| abstract class AbstractAbrisRegistryClient(client: SchemaRegistryClient) extends AbrisRegistryClient { |
There was a problem hiding this comment.
Could this be renamed to AbstractConfluentRegistryClient?
Abris Client - not dependent on implementation
Confluent Client - depends on confluent
There was a problem hiding this comment.
Yeah that makes sense
cerveada
approved these changes
Dec 22, 2021
gintautassulskus-elsevier
pushed a commit
to gintautassulskus-elsevier/ABRiS
that referenced
this pull request
Feb 4, 2022
AbsaOSS#262) * Extract common logic to abstract class, replace deprecated client methods * PR fix: Rename abstract class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hods
Closes #257