-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract common logic to abstract class, replace deprecated client met… #262
Merged
kevinwallimann
merged 2 commits into
master
from
feature/257-confluent-deprecated-methods
Dec 22, 2021
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
src/main/scala/za/co/absa/abris/avro/registry/AbstractAbrisRegistryClient.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright 2020 ABSA Group Limited | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package za.co.absa.abris.avro.registry | ||
|
||
import io.confluent.kafka.schemaregistry.avro.AvroSchema | ||
import io.confluent.kafka.schemaregistry.client.{SchemaMetadata, SchemaRegistryClient} | ||
import org.apache.avro.Schema | ||
|
||
import java.util | ||
|
||
|
||
abstract class AbstractAbrisRegistryClient(client: SchemaRegistryClient) extends AbrisRegistryClient { | ||
|
||
override def getAllVersions(subject: String): util.List[Integer] = | ||
client.getAllVersions(subject) | ||
|
||
override def testCompatibility(subject: String, schema: Schema): Boolean = | ||
client.testCompatibility(subject, new AvroSchema(schema)) | ||
|
||
override def register(subject: String, schema: Schema): Int = | ||
client.register(subject, new AvroSchema(schema)) | ||
|
||
override def getLatestSchemaMetadata(subject: String): SchemaMetadata = | ||
client.getLatestSchemaMetadata(subject) | ||
|
||
override def getSchemaMetadata(subject: String, version: Int): SchemaMetadata = | ||
client.getSchemaMetadata(subject, version) | ||
|
||
override def getById(schemaId: Int): Schema = { | ||
val parsedSchema = client.getSchemaById(schemaId) | ||
parsedSchema match { | ||
case schema: AvroSchema => schema.rawSchema() | ||
case schema => throw new UnsupportedOperationException(s"Only AvroSchema is supported," + | ||
s" got schema type ${schema.schemaType()}") | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be renamed to
AbstractConfluentRegistryClient
?Abris Client - not dependent on implementation
Confluent Client - depends on confluent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense