Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New main function combining Standardization and Confromance #1371

Closed
benedeki opened this issue Jun 1, 2020 · 3 comments · Fixed by #1392
Closed

New main function combining Standardization and Confromance #1371

benedeki opened this issue Jun 1, 2020 · 3 comments · Fixed by #1392
Assignees
Labels
Conformance Conformance Job affected feature New feature priority: medium Important but not urgent Standardization Standardization Job affected

Comments

@benedeki
Copy link
Collaborator

benedeki commented Jun 1, 2020

Background

Being able to run Standardization and Conformance in succession with only one initialization would improve the efficiency of the whole process.

Feature

Create a new object with main function that will run Standardization and Conformance logic in one call, combining the logic,

Proposed Solution [Optional]

Solution Ideas

  1. Leverage the classes/traits from Extract common parts from Standardization and Conformance jobs #1015, Extract most/all logic from StandardizationJob #1231 and Extract most/all logic from DynamicConformanceJob #1232
@benedeki benedeki added Conformance Conformance Job affected feature New feature priority: medium Important but not urgent Standardization Standardization Job affected labels Jun 1, 2020
@AdrianOlosutean AdrianOlosutean self-assigned this Jun 11, 2020
@AdrianOlosutean
Copy link
Contributor

Should this combined job be writing the standardization results as an intermediate step or not? Or should it should be configurable?

@benedeki
Copy link
Collaborator Author

Should this combined job be writing the standardization results as an intermediate step or not? Or should it should be configurable?

Definitely at least in the first version write the output of Standardization. Also as a precaution, if Conformance would fail, to have at least the work done saved.
(in subsequent eventual improvements we can make it more sophisticated)

AdrianOlosutean pushed a commit that referenced this issue Jun 11, 2020
AdrianOlosutean pushed a commit that referenced this issue Jun 25, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 14, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 23, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 23, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 24, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 27, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 27, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 28, 2020
AdrianOlosutean pushed a commit that referenced this issue Jul 29, 2020
@AdrianOlosutean
Copy link
Contributor

AdrianOlosutean commented Jul 30, 2020

Release notes:
It's now possible to run Standardization and Conformance at once instead of one after each other. This is suitable when their resource requirements are rather similar and it saves time by initializing only once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance Conformance Job affected feature New feature priority: medium Important but not urgent Standardization Standardization Job affected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants