Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to rerun Standardization if Conformance failed #2188

Open
benedeki opened this issue Apr 16, 2023 · 2 comments
Open

Make it easier to rerun Standardization if Conformance failed #2188

benedeki opened this issue Apr 16, 2023 · 2 comments
Labels
feature New feature priority: medium Important but not urgent Standardization Standardization Job affected under discussion Requires consideration before a decision is made whether/how to implement
Milestone

Comments

@benedeki
Copy link
Collaborator

Background

If Conformance phase fails it leaves behind the temporary files created by Standardization. That prevents Standardization to re-run easily.

Feature

Find and implement a way to make Standardization re-run easier.

Proposed Solution

Solution Ideas:

  1. If auto-clean option is on delete the Standardization target directory if it exists instead of failing
  2. Introduce a new switch force that will ignore the existence of target directory and delete it first if it exists.
@benedeki benedeki added feature New feature under discussion Requires consideration before a decision is made whether/how to implement Standardization Standardization Job affected priority: medium Important but not urgent labels Apr 16, 2023
@benedeki benedeki added this to the Release 3.1 milestone Apr 16, 2023
@benedeki
Copy link
Collaborator Author

Is _Standardization) re-run easier and cheaper than detecting the presence of the target directory?

@yruslan
Copy link
Contributor

yruslan commented Apr 17, 2023

Thanks for the ticket. I like both solution ideas. Maybe the solution 2 actually makes more sense. '--force' can be used only on re-runs, and can do deletions for publish folders as well.

Yes, definitely adding auto-deletion on re-run will make it much easier, cheaper and also less error-prone. Since currently a person needs to delete corresponding folders manually, and can delete a wrong folder just by accident, especially if many re-runs are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature priority: medium Important but not urgent Standardization Standardization Job affected under discussion Requires consideration before a decision is made whether/how to implement
Projects
None yet
Development

No branches or pull requests

2 participants