Update frontend dependencies and example endpoints #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adairrr
requested review from
CyberHoward and
Buckram123
and removed request for
CyberHoward
adairrr
changed the title
|
@Buckram123 we need to update the publisher stuff in the publish scripts and the integration tests... not sure what is proper anymore. |
Buckram123
reviewed
Nov 1, 2024
| .publisher_builder(adapter_namespace) | ||
| .build()?; | ||
| // Get the [`Account`] that owns the namespace, otherwise create a new one and claim the namespace | ||
| let publisher_acc = abstract_client.fetch_or_build_account(adapter_namespace, |builder| builder.namespace(Namespace::from_id({{adapter_name | shouty_snake_case}}_ID).unwrap()))?; |
There was a problem hiding this comment.
Would be nice to just clone namespace, but "builder fn" doesn't capture environment, as it's function instead of closure, fixed in AbstractSDK/abstract#519
Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the frontend dependencies and example endpoints.