Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sockets - Shubha #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sockets - Shubha #34

wants to merge 2 commits into from

Conversation

shubha-rajan
Copy link

No description provided.

jadevance
jadevance reviewed Apr 21, 2019
View reviewed changes
lib/factorial.rb
end
return factorial
else
raise ArgumentError, "Input must be an integer"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend having error handling at the top rather than the bottom so you break early. Something such as:

if !number 
  raise
else 
  do factorial
end

Otherwise good job on this assignment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadevance jadevance jadevance left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubha-rajan @jadevance