Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports - sav #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions lib/factorial.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
# Computes factorial of the input number and returns it
# Time complexity: ?
# Space complexity: ?
def factorial(number)
raise NotImplementedError
# Time complexity: 0(n) where n is the size of the number factorial is called on.
# Space complexity: 0(1)

# unsure how to do time and space analysis on recursive functions.

# def factorial(number)
# raise ArgumentError.new unless number
# number > 0 ? number * factorial(number - 1) : 1
# end

def factorial(n)
raise ArgumentError.new unless n
fact = 1
until n == 0
fact *= n
n -= 1
end
return fact
end