-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sockets - Karla Guadron #50
base: master
Are you sure you want to change the base?
Conversation
Portmanteau GeneratorWhat We're Looking For
Great job overall! I've left a few comments inline below where things could be cleaned up, but in general I am quite happy with this submission. Keep up the hard work! |
def is_vowel?(letter) | ||
if letter =~ /[aeiou]/ | ||
return true | ||
elsif letter !~ /[aeiou]/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of a regular expression here! We'll talk about those more formally in a few weeks.
puts "What is the second word?" | ||
word_two = gets.chomp | ||
until word_two.length >= 2 | ||
puts "Your word must have at least 2 characters. Please enter something else" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code to get the second word is almost exactly the same as the code to get the first word. Could you DRY this up using another method?
Portmanteau Generator
Congratulations! You're submitting your assignment.
Comprehension Questions
is_vowel?
method affect your project?