diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 5204edb..2f97d13 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,8 +1,23 @@ -# Time Complexity: ? -# Space Complexity: ? +# Time Complexity: O(n) +# Space Complexity: O(1) +# resource: https://www.geeksforgeeks.org/largest-sum-contiguous-subarray/ def max_sub_array(nums) return 0 if nums == nil - - raise NotImplementedError, "Method not implemented yet!" + # Initialize: + max_so_far = nums[0] + max_ending_here = nums[0] + +# Loop for each element of the array + i = 1 + while i < nums.length + max_ending_here = max_ending_here + nums[i] + if max_so_far < max_ending_here + max_so_far = max_ending_here + elsif max_ending_here < 0 + max_ending_here = 0 + end + i+=1 + end + return max_so_far end diff --git a/lib/newman_conway.rb b/lib/newman_conway.rb index 4c985cd..1668d1b 100644 --- a/lib/newman_conway.rb +++ b/lib/newman_conway.rb @@ -1,7 +1,22 @@ -# Time complexity: ? -# Space Complexity: ? +# Time complexity: O(n) +# Space Complexity: O(n) +# resource: https://www.geeksforgeeks.org/print-n-terms-newman-conway-sequence/ def newman_conway(num) - raise NotImplementedError, "newman_conway isn't implemented" + raise ArgumentError if num == 0 + return "1" if num == 1 + return "1 1" if num == 2 + arr = [] + arr[0] = 0 + arr[1] = 1 + arr[2] = 1 + result = "1 1" + i = 3 + while i <= num + arr[i] = arr[arr[i - 1]] + arr[i - arr[i - 1]] + result += " #{arr[i]}" + i += 1 + end + return result end \ No newline at end of file diff --git a/test/max_sub_array_test.rb b/test/max_sub_array_test.rb index 3253cdf..e27e1ca 100644 --- a/test/max_sub_array_test.rb +++ b/test/max_sub_array_test.rb @@ -1,6 +1,6 @@ require_relative "test_helper" -xdescribe "max subarray" do +describe "max subarray" do it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do # Arrange input = [-2,1,-3,4,-1,2,1,-5,4]