Yieni-Space #30
Open
Yieni-Space #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 1, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You did well on the methods you did finish. Take a look at my few comments and let me know what questions you have.
Comment on lines
+21
to
23
| # Time Complexity: O(1)? | ||
| # Space Complexity: O(1)? | ||
| def add_first(value) |
Comment on lines
+31
to
33
| # Time Complexity: o(n)? | ||
| # Space Complexity: O(1)? | ||
| def search(value) |
Comment on lines
44
to
46
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+60
to
62
| # Time Complexity: O(n)? | ||
| # Space Complexity: O(1)? | ||
| def find_min |
Comment on lines
75
to
77
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def length |
Comment on lines
+96
to
+98
| index.times do | ||
| current = current.next | ||
| end |
Comment on lines
90
to
92
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_at_index(index) |
Comment on lines
103
to
105
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def visit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
Sorry couldn't finish the last two. I don't feel good and I hit my wall.