From 76e538ca5f086fa99328dc10a05e7ca581457192 Mon Sep 17 00:00:00 2001 From: Alex Povel Date: Thu, 21 Jan 2021 15:07:11 +0100 Subject: [PATCH] Remove Docker VOLUME instruction for more flexibility Inheriting from the base image is made easier without the VOLUME instruction, since it cannot be reverted. All guides contain `--volume` explanations/usage examples anyway, so the VOLUME instructions in the Dockerfile aren't necessary. See also https://stackoverflow.com/a/62068396/11477374 for more examples for why that instruction can be harmful. --- scripts/make/Dockerfile | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/make/Dockerfile b/scripts/make/Dockerfile index 7e9bec86fb5..0dc2378da90 100644 --- a/scripts/make/Dockerfile +++ b/scripts/make/Dockerfile @@ -35,8 +35,6 @@ RUN setcap 'cap_net_bind_service=+eip' /opt/adguardhome/AdGuardHome EXPOSE 53/tcp 53/udp 67/udp 68/udp 80/tcp 443/tcp 853/tcp 3000/tcp -VOLUME ["/opt/adguardhome/conf", "/opt/adguardhome/work"] - WORKDIR /opt/adguardhome/work ENTRYPOINT ["/opt/adguardhome/AdGuardHome"]