diff --git a/CHANGELOG.md b/CHANGELOG.md index e63c913cd09..46c421ba554 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -56,6 +56,13 @@ and this project adheres to [#2391]: https://github.com/AdguardTeam/AdGuardHome/issues/2391 [#2394]: https://github.com/AdguardTeam/AdGuardHome/issues/2394 +### Deprecated + +- _Go_ 1.14 support. v0.106.0 will require at least _Go_ 1.15 to build. +- The `darwin/386` port. It will be removed in v0.106.0. +- The `"rule"` and `"filter_id"` fields in `GET /filtering/check_host` and + `GET /querylog` responses. They will be removed in v0.106.0 ([#2102]). + ### Fixed - Inability to set DNS cache TTL limits ([#2459]). diff --git a/HACKING.md b/HACKING.md index a16d6496de0..237e554f1df 100644 --- a/HACKING.md +++ b/HACKING.md @@ -70,6 +70,14 @@ The rules are mostly sorted in the alphabetical order. func TestType_Method_suffix(t *testing.T) { /* … */ } ``` + * Name parameters in interface definitions: + + ```go + type Frobulator interface { + Frobulate(f Foo, b Bar) (r Result, err error) + } + ``` + * Name the deferred errors (e.g. when closing something) `cerr`. * No shadowing, since it can often lead to subtle bugs, especially with @@ -172,10 +180,15 @@ The rules are mostly sorted in the alphabetical order. * Put utility flags in the ASCII order and **don't** group them together. For example, `ls -1 -A -q`. - * `snake_case`, not `camelCase`. + * `snake_case`, not `camelCase` for variables. `kebab-case` for filenames. + + * UPPERCASE names for external exported variables, lowercase for local, + unexported ones. * Use `set -e -f -u` and also `set -x` in verbose mode. + * Use `readonly` liberally. + * Use the `"$var"` form instead of the `$var` form, unless word splitting is required.