Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to disable first-level domain cosmetic rules with second-level allowlist rules for a specific domain #61

Open
4 of 5 tasks
piquark6046 opened this issue Jun 19, 2024 · 3 comments
Assignees
Labels
bug Something isn't working Priority: P4

Comments

@piquark6046
Copy link
Member

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.5.3

Environment

  • OS: 17.5.1
  • Device: iPhone 15

Ad Blocking

No response

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

List-KR

Advanced protection for Safari

  • yes, I do

Which DNS server do you use?

AdGuard DNS Non-filtering

DNS protocol

DNS-over-QUIC

Custom DNS

No response

DNS filtering

  • yes, I do

Custom DNS filter

No response

DNS implementation

AdGuard

Tunnel mode

Split-Tunnel

Low-level settings

Bootstrap server:
Fallback server:
Blocking mode, etc:

Issue Details

Steps to reproduce:

  1. Enable List-KR filters list.
  2. Visit https://board.namu.wiki/
  3. Click one of the posts.

Expected Behavior

The following rules should exclude the normal cosmetic rules at board.namu.wiki.

board.namu.wiki#@#div[class] ~ div div + *[class]:not([class*=" "]) *[class*=" "] div[class]:has(iframe[id^="google_ads_"])
board.namu.wiki#@#div[class] ~ div div + *[class]:not([class*=" "]) *[class*=" "] div[class]:has(iframe[src*="arca.live/external/callad"])
board.namu.wiki#@#div:not([class*=" "]) ~ div div + div[class]:has(> div[id][class])
board.namu.wiki#@#div[class]:not([class*=" "]) ~ div[class*=" "] > *[class*=" "] > *:has(iframe[id^="google_ads_iframe_"])
board.namu.wiki#@#*[class]:not([class*=" "]) > div[class]:not([class*=" "]) ~ *:not([class]) > *[class]:has(iframe[id^="google_ads_iframe_"])
board.namu.wiki#@#*[class]:not([class*=" "]) > div[class]:not([class*=" "]) ~ *:not([class]) > *[class]:has(iframe[src*="arca.live/external/callad"])
board.namu.wiki#@#div[class]:not([class*=" "]) ~ div[class*=" "] > *[class*=" "] > *:has(iframe[src*="arca.live/external/callad"])
namu.wiki##div[class] ~ div div + *[class]:not([class*=" "]) *[class*=" "] div[class]:has(iframe[id^="google_ads_"])
namu.wiki##div[class] ~ div div + *[class]:not([class*=" "]) *[class*=" "] div[class]:has(iframe[src*="arca.live/external/callad"])
namu.wiki##div:not([class*=" "]) ~ div div + div[class]:has(> div[id][class])
namu.wiki##div[class]:not([class*=" "]) ~ div[class*=" "] > *[class*=" "] > *:has(iframe[id^="google_ads_iframe_"])
namu.wiki##*[class]:not([class*=" "]) > div[class]:not([class*=" "]) ~ *:not([class]) > *[class]:has(iframe[id^="google_ads_iframe_"])
namu.wiki##*[class]:not([class*=" "]) > div[class]:not([class*=" "]) ~ *:not([class]) > *[class]:has(iframe[src*="arca.live/external/callad"])
namu.wiki##div[class]:not([class*=" "]) ~ div[class*=" "] > *[class*=" "] > *:has(iframe[src*="arca.live/external/callad"])

Actual Behavior

Allowing the cosmetic rules does not work.

Screenshots

No response

Additional Information

List-KR/List-KR#935

@piquark6046 piquark6046 added the bug Something isn't working label Jun 19, 2024
@Versty
Copy link

Versty commented Jun 27, 2024

@piquark6046 Hi!
Could you please explain which filters in the List-KR contain blocking and unblocking rules you mentioned?

@piquark6046
Copy link
Member Author

#61
Here: filters-AG/specific_ELEMHIDE.txt

@Versty
Copy link

Versty commented Aug 1, 2024

@piquark6046 Currently unblocking cosmetic rules #@# for subdomains is not supported while the domain is blocked by contrary rule. We will consider improvements to Safari Converter to handle this type of cases.

@adguard-bot adguard-bot assigned maximtop and unassigned Versty Aug 1, 2024
@vozersky vozersky transferred this issue from AdguardTeam/AdguardForiOS Aug 1, 2024
@maximtop maximtop changed the title Allowing a a cosmetic rule does not work at board.namu.wiki Add the ability to disable first-level domain cosmetic rules with second-level allowlist rules for a specific domain Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: P4
Projects
None yet
Development

No branches or pull requests

4 participants