Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check on compatibility of parameter bounds with scaling_uncertainties and other features #105

Open
AdityaSavara opened this issue May 4, 2020 · 3 comments
Labels
good first issue Good for newcomers wontfix This will not be worked on

Comments

@AdityaSavara
Copy link
Owner

As noted in this pull request,
#88

We have the following possibilities:

Uncertainties scaling can now be turned off, by parameter_estimation_settings['scaling_uncertainties_type'] = 'off'
Uncertainties scaling can now be done by a fixed constant by using a string that is a number, like this: parameter_estimation_settings['scaling_uncertainties_type'] = '1e3'

The default is "std".

However, we now have parameter bounds with
InputParameterPriorValues_upperBounds
InputParameterPriorValues_lowerBounds

This works with "off" for the scaling. It probably does not yet work for any other scaling.

##As of May 4th 2020, this only has been checked for scaling_uncertainties_type = 'off'

@AdityaSavara AdityaSavara added good first issue Good for newcomers wontfix This will not be worked on labels May 4, 2020
@AdityaSavara
Copy link
Owner Author

AdityaSavara commented May 5, 2020

it mightbe useful to put InputParameterPriorValues_upperBounds and the lower bound one in the mcmc sampling directly rather than just the likelihood, but we have to keep it in the likelihood as well in case somebody uses gridsearch or direct sampling.

There are two ways of implementing: One could include it in samples as "zero" probability (logP='-inf') without checking prior and likelihood, or one could even exclude it from the sampling. Both ways make sense to me.

@AdityaSavara AdityaSavara changed the title check on compatibility of parameter bounds with scaling_uncertainties check on compatibility of parameter bounds with scaling_uncertainties and other features May 10, 2020
@AdityaSavara
Copy link
Owner Author

AdityaSavara commented May 10, 2020

  • The bounds should be made compatible with reducedParameterSpace (done October 9th 2021)

@AdityaSavara
Copy link
Owner Author

The bounds check is currently designed that if somebody puts a bound of 0 that excludes 0 from being allowed.

  • There should probably be an option to specify whether the bound value should be allowed or disallowed. [low priority, won't implement at the moment]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant