Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evidence line is incorrect. #67

Closed
AdityaSavara opened this issue Mar 21, 2020 · 2 comments
Closed

evidence line is incorrect. #67

AdityaSavara opened this issue Mar 21, 2020 · 2 comments
Assignees
@walke299ericwalk
Labels
bug Something isn't working required

Comments

@AdityaSavara
Copy link
Owner

FIXME: Below line is not correct in code as of March 21, 2020. Should not be the log of the posteriors, should be the posteriors directly. Ashi Messed it up, but is leaving it for Eric to fix.

self.evidence = np.mean(self.post_burn_in_log_posteriors_un_normed_vec)np.sqrt(2np.pi*np.std(self.post_burn_in_samples)**2)
@AdityaSavara AdityaSavara added bug Something isn't working required labels Mar 21, 2020
@AdityaSavara
Copy link
Owner Author

AdityaSavara commented Mar 22, 2020 •
edited
Loading

This error was introduced in this pull request: #66

@AdityaSavara AdityaSavara mentioned this issue Mar 22, 2020
Merged
@AdityaSavara
Copy link
Owner Author

Was fixed in this pull request 403dacd

@AdityaSavara AdityaSavara mentioned this issue Apr 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walke299ericwalk walke299ericwalk

Labels
bug Something isn't working required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdityaSavara @walke299ericwalk