-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncertainties Scaling Improvements & Info gain debugged (fixed) #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To temporarily bypass scaling bugs, this branch includes the following line added: self.UserInput.scaling_uncertainties = self.UserInput.scaling_uncertainties/self.UserInput.scaling_uncertainties That sets the scaling factors for uncertainties to 1.0 for every parameter.
Corrected scaling bug, added "constant/fixed" scaling Also made some directories to investigate the effects of scaling on Example 12
Removing unnecessary print statement and fixing and converty from try/except to "if" statement for 0 probability cases of simulation failure.
UserInput now has a variable like this: UserInput.parameter_estimation_settings['mcmc_info_gain_cutoff'] = 1E-5
parameter_estimation_settings['undo_scaling_uncertainties_type'] = True will undo the scaling. Now we see that 1E13 and the unscaled case are the same.
…ff'] feature UserInput.parameter_estimation_settings['mcmc_info_gain_cutoff']
I think I found an error. I think this line: post_burn_in_log_posteriors_vec = self.post_burn_in_log_posteriors_un_normed_vec/self.evidence I think it should be like this: post_burn_in_log_posteriors_vec = log( np.exp(self.post_burn_in_log_posteriors_un_normed_vec) /self.evidence )
Competitive Langmuir adsorption example
walke299ericwalk
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has a fairly substantial set of improvements. Several arguments have been added to UserInput, a few if statements to the code, and some bugs fixed.