Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime actions #144

Merged
merged 14 commits into from
Feb 23, 2024
Merged

runtime actions #144

merged 14 commits into from
Feb 23, 2024

Conversation

jhadobe
Copy link
Contributor

@jhadobe jhadobe commented Feb 6, 2024

This PR attempts to create a single page from the 20+ README files from the original project. They mainly differed in code samples, so I've used the combined code blocks from the aio-theme to reduce clutter.

I've added a blank index.md page as a placeholder.

staging: https://adobedocs.github.io/commerce-extensibility/app-development/starter-kit/integration/

@jhadobe jhadobe added major-update Significant original updates to existing content new-topic A major update published as an entirely new document labels Feb 6, 2024
@jhadobe jhadobe self-assigned this Feb 6, 2024
@jhadobe
Copy link
Contributor Author

jhadobe commented Feb 6, 2024

i still need to add/customize the images.

@jhadobe
Copy link
Contributor Author

jhadobe commented Feb 7, 2024

TabsBlock would benefit from different styling. using an image makes it more obvious that they are interactive, but we would need images for: customer, customer_group, product, stock, etc. i'm also uncertain how difficult the code block files will be to maintain, but i think this makes for a better user experience.

@jhadobe jhadobe marked this pull request as ready for review February 16, 2024 17:42
@keharper keharper added the internal Differentiates work between external and internal contributors label Feb 16, 2024
Copy link
Collaborator

@rojoangel rojoangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job removing redundancy & duplication 👏
Recently we added some more details to our README that could be useful to add more context to this page. In particular this section could be of your interest: Different types of actions included in the starter kit. The section explains the two main action types used in the starter-kit:

src/pages/app-development/starter-kit/integration.md Outdated Show resolved Hide resolved
src/pages/app-development/starter-kit/integration.md Outdated Show resolved Hide resolved
src/pages/app-development/starter-kit/integration.md Outdated Show resolved Hide resolved
src/pages/app-development/starter-kit/integration.md Outdated Show resolved Hide resolved
src/pages/app-development/starter-kit/integration.md Outdated Show resolved Hide resolved
jhadobe and others added 3 commits February 20, 2024 10:41
@jhadobe
Copy link
Contributor Author

jhadobe commented Feb 20, 2024

Nice job removing redundancy & duplication 👏 Recently we added some more details to our README that could be useful to add more context to this page. In particular this section could be of your interest: Different types of actions included in the starter kit. The section explains the two main action types used in the starter-kit:

Thanks @rojoangel! We will add those sections in a future PR.

@keharper
Copy link
Contributor

@rojoangel Can we get an approval on this PR?

@jhadobe jhadobe merged commit 0ba45d5 into starter-kit-develop Feb 23, 2024
4 checks passed
@jhadobe jhadobe deleted the jh_crud branch February 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Differentiates work between external and internal contributors major-update Significant original updates to existing content new-topic A major update published as an entirely new document
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants