Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhooks #156

Merged
merged 11 commits into from
Mar 25, 2024
Merged

Webhooks #156

merged 11 commits into from
Mar 25, 2024

Conversation

jhadobe
Copy link
Contributor

@jhadobe jhadobe commented Feb 26, 2024

Purpose of this pull request

This pull request (PR) adds a webhook configuration example to the starter kit docs.

@jhadobe jhadobe added the new-topic A major update published as an entirely new document label Feb 26, 2024
@jhadobe jhadobe self-assigned this Feb 26, 2024
@jhadobe jhadobe marked this pull request as ready for review February 26, 2024 21:32
rojoangel
rojoangel approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@rojoangel rojoangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a statement at the beginning of the doc to explain that the starter kit supports webhooks and that this is an example/reference implementation about how to use them to check stock availability.

Good job!

jhadobe and others added 3 commits February 27, 2024 08:54
@jhadobe jhadobe marked this pull request as draft February 28, 2024 23:42
@jhadobe jhadobe requested a review from rojoangel March 6, 2024 22:55
@jhadobe
Copy link
Contributor Author

jhadobe commented Mar 6, 2024

@rojoangel can you re-review? I've rearranged the webhooks example and added ingestion webhooks coverage.
Additionally, can you tell me what set up in the Adobe Commerce admin is required to get hooks to work? (outside of initial setup of the Starter Kit).

@jhadobe jhadobe marked this pull request as ready for review March 6, 2024 22:58
rojoangel
rojoangel approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@rojoangel rojoangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/pages/app-development/starter-kit/webhook-ingestion.md Outdated Show resolved Hide resolved
src/pages/app-development/starter-kit/webhooks-example.md Outdated Show resolved Hide resolved
@jhadobe jhadobe requested a review from keharper March 22, 2024 20:50
@jhadobe jhadobe merged commit 450e708 into starter-kit-develop Mar 25, 2024
4 checks passed
@jhadobe jhadobe deleted the jh_hooks branch March 25, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rojoangel rojoangel rojoangel approved these changes

@ahajji87 ahajji87 ahajji87 approved these changes

@keharper keharper keharper approved these changes

Assignees

@jhadobe jhadobe

Labels
new-topic A major update published as an entirely new document
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhadobe @ahajji87 @rojoangel @keharper