[Feature] Better ErrorEvents #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboynton97
reviewed
Apr 19, 2024
| @@ -80,7 +80,7 @@ def on_llm_error( | |||
| llm_event: LLMEvent = self.events.llm[str(run_id)] | |||
| self.ao_client.record(llm_event) | |||
|
|
|||
| error_event = ErrorEvent(trigger_event=llm_event, details=str(error), timestamp=get_ISO_time()) | |||
| error_event = ErrorEvent(trigger_event=llm_event, error_type=type(error).__name__, details=str(error), timestamp=get_ISO_time()) | |||
There was a problem hiding this comment.
I was thinking more like
error_event = ErrorEvent(trigger_event=llm_event, error=error)
and then the ErrorEvent constructor does the rest:
def __init__(self, trigger_event, error):
self.error_type = error_type=type(error).__name__
self.details = str(error)
self.timestamp = get_ISO_time()it's less work for the developer to have to do. more magic
There was a problem hiding this comment.
or actually maybe like this
def __init__(self, trigger_event, error, error_type = None, details = None, timestamp = None):
self.error_type = error_type or error_type=type(error).__name__
self.details = details or str(error)
self.timestamp = timestamp or get_ISO_time()
|
Howard is doing a better version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
📘 Description
We are currently not recording the error types anywhere and instead loading it into the details field. This change makes use of the error types field and automatically captures stack traces.
Need recommendations for names for the Langchain handler!
@HowieG, are all of the fields in ErrorEvent sent to the API server? Is there a way for us to create an exceptions field that auto populates the error_type and details fields (if they aren't provided)?