Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and push a 'use' image for each proposal #25

Closed
turadg opened this issue Nov 10, 2023 · 1 comment · Fixed by #69
Closed

build and push a 'use' image for each proposal #25

turadg opened this issue Nov 10, 2023 · 1 comment · Fixed by #69
Assignees

Comments

@turadg
Copy link
Member

turadg commented Nov 10, 2023

Problem to solve

Downstream integration tests rely on a synthetic state of Mainnet. For example, the upgrade-12 test in agoric-sdk.

While developing, it needs a branch that reflects the complete history of passed proposals. This repo publishes that as main (since #24)

However, once upgrade-12 itself passes and is incorporated into main, that test will begin to fail. Even though the proposal is done and passed, we shouldn't break the CI of the branch that tested it.

Design

So this repo should publish an image for using the chain after each proposal. (i.e. an image for each use-${proposalName} stage)

There should still be a main image because all the "use" images have a RUN that terminates (for use in tests) but we want to offer an image that developers can use to run the chain with the latest synthetic state of Mainnet.

@mhofman
Copy link
Member

mhofman commented Jan 14, 2024

I am currently working around this by manually creating an upgrade-12 branch (and later upgrade-13) containing only the required layers, and using GH actions trigger to generate a tagged image.

@turadg turadg assigned turadg and unassigned ivanlei Jan 16, 2024
This was referenced Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants