Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to limit excess authority when registering a vbank asset #10722

Open
dckc opened this issue Dec 17, 2024 · 0 comments
Open

how to limit excess authority when registering a vbank asset #10722

dckc opened this issue Dec 17, 2024 · 0 comments
Labels

Comments

@dckc
Copy link
Member

dckc commented Dec 17, 2024

What is the Problem Being Solved?

#10709 uses the usual E(bankManager).addAsset(...) idiom to register FastLP. But bankManager has much more authority than this: it can create a vbank purse for any address and then withdraw from it.

Description of the Design

TBD

Security Considerations

yes

Scaling Considerations

?

Test Plan

Upgrade Considerations

@dckc dckc added enhancement New feature or request needs-design core-eval labels Dec 17, 2024
mergify bot added a commit that referenced this issue Dec 18, 2024
closes: #10703

## Description

 - add `FastLP` / `ufastlp` to vbank

### Security Considerations

Adds `bankManager` to the FastUSDC core eval permit, which introduces an audit burden to see that is used only for the relevant `addAsset` call.

 - #10722

### Scaling Considerations

eliminates up-calls from go to JS on each FastLP balance update

### Documentation Considerations

Existing docs suffice; to wit: [VBank Assets and Cosmos Bank Balances](https://docs.agoric.com/guides/getting-started/contract-rpc.html#vbank-assets-and-cosmos-bank-balances)

### Testing Considerations

 - update tests that relied on getting FastLP balances from `published.wallet.${addr}.current`.

### Upgrade Considerations

unreleased
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant