Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move definition of Passable type from notifier package to marshal. #1958

Closed
erights opened this issue Nov 2, 2020 · 0 comments · Fixed by #2548
Closed

Move definition of Passable type from notifier package to marshal. #1958

erights opened this issue Nov 2, 2020 · 0 comments · Fixed by #2548
Assignees
Labels
bug Something isn't working

Comments

@erights
Copy link
Member

erights commented Nov 2, 2020

As of #1949 we have a temporary definition of the Passable type at

/**
* @typedef {*} Passable
* A value that can be passed between vats.
* TODO This type should be exported by `@agoric/marshal` and imported here.
* TODO For these tools to be used for distributed operation, we need a less
* precise comparison than `t.is` when testing that these values have arrived.
*/

Instead, the marshal package needs to be typed, and it should be the one to export a Passable type. Such a typed marshal package can and should be extracted from #1905 's https://github.com/Agoric/agoric-sdk/tree/amount-patterns/packages/marshal/src

@erights erights added the bug Something isn't working label Nov 2, 2020
@erights erights mentioned this issue Nov 2, 2020
@erights erights self-assigned this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant