Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart wallet can trade with small # of users #5354

Closed
11 tasks done
turadg opened this issue May 12, 2022 · 3 comments
Closed
11 tasks done

Smart wallet can trade with small # of users #5354

turadg opened this issue May 12, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request Epic read-no-tx topic: reading from the chain without a transaction user-story User story that needs to be implemented and tested. wallet

Comments

@turadg turadg added enhancement New feature or request Epic wallet labels May 12, 2022
@dckc
Copy link
Member

dckc commented May 12, 2022

I was thinking the main point here is that the only cosmos level transaction we have to sign to make an AMM trade is to accept the offer.

@samsiegart pointed out that this might not be feasible; we might need another one to get an invitation. #3908 is about getting an offer from a dapp to the wallet without going thru the chain.

In any case, the "two browser tabs" angle is only tangentially relevant.

@dckc dckc added the read-no-tx topic: reading from the chain without a transaction label May 31, 2022
@michaelfig michaelfig changed the title On-chain wallet can trade with small # of users Smart wallet can trade with small # of users Jun 3, 2022
@dckc
Copy link
Member

dckc commented Aug 2, 2022

@samsiegart where are we now? Would you please add

@dckc
Copy link
Member

dckc commented Aug 17, 2022

yay! we landed all the pieces. Let's use #5073 to track end-to-end testing.

@dckc dckc closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic read-no-tx topic: reading from the chain without a transaction user-story User story that needs to be implemented and tested. wallet
Projects
None yet
Development

No branches or pull requests

4 participants