Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential await hazard in liquidateIncrementally #6220

Closed
erights opened this issue Sep 16, 2022 · 2 comments
Closed

potential await hazard in liquidateIncrementally #6220

erights opened this issue Sep 16, 2022 · 2 comments
Assignees
Labels
bug Something isn't working Inter-protocol Overarching Inter Protocol security vaults_triage DO NOT USE Vaults VaultFactor (née Treasury)

Comments

@erights
Copy link
Member

erights commented Sep 16, 2022

  // This await almost certainly does not do what was intended.
  // `oncePerBlock()` returns an async generator, not a promise,
  // and does nothing observably effectful to anyone not pulling on
  // the generator, which this code drops. AFAICT, this code is
  // equivalent to `await null;`. It imposes a non-delayed turn boundary
  // and does nothing else.

(Noticed while doing #6219 )

@erights erights added the bug Something isn't working label Sep 16, 2022
@erights erights self-assigned this Sep 16, 2022
@dckc dckc added Inter-protocol Overarching Inter Protocol Vaults VaultFactor (née Treasury) labels Sep 16, 2022
@ivanlei ivanlei added the vaults_triage DO NOT USE label Jan 17, 2023
@turadg turadg changed the title await oncePerBlock() not doing what you intended. potential await hazard in liquidateIncrementally Jan 25, 2023
@turadg
Copy link
Member

turadg commented Jan 25, 2023

Dropping from Vaults Release as we're not using liquidateIncrementally there. @Chris-Hibbert is replacing liquidation.

@turadg
Copy link
Member

turadg commented Mar 30, 2023

Obsolete as the module was removed

@turadg turadg closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Inter-protocol Overarching Inter Protocol security vaults_triage DO NOT USE Vaults VaultFactor (née Treasury)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants