Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Extension pulls from "community-dev" branch #6419

Closed
cboydstun opened this issue Oct 7, 2022 · 9 comments
Closed

VS Code Extension pulls from "community-dev" branch #6419

cboydstun opened this issue Oct 7, 2022 · 9 comments
Assignees
Labels
bounty enhancement New feature or request vaults_triage DO NOT USE

Comments

@cboydstun
Copy link

Description

Update the Agoric VS Code Extension so that it clones and installs the "community-dev" branch for users to build on.

Context

The "master" branch of our SDK is under constant development and is currently optimized for our parity stability module. We want our community of developers to have access to a stable release of the SDK for them to experiment with.

Acceptance Criteria

  1. VS Code Extension installs the "community-dev" branch of the Agoric SDK
  2. Keyword "agoric" is available from the terminal command line
  3. Code is open sourced and submission includes a video walkthrough/demo

Time Estimation

3 hours

Reward

$240

Payment will be made in USD (fiat currency) via wire transfer. The developer is responsible for providing their completed tax documents (W9 for US based developers and/or W8 or W8-BEN-E for non-US based developers) and providing their banking details in order to receive payment.

Applicant Assessment Criteria

Important: Please provide a clear work plan for how you will approach this bounty. Use the work plan as an initial demonstration that you would be a good candidate. Bounties will require coordination with the Agoric team, so unfortunately only plans submitted in English will be considered.

Applicants will be assessed based on the following criteria:

  • Issue-specific domain experience
  • Issue-specific technical capability
  • Familiarity with Agoric's platform
  • JavaScript experience
  • Availability and communication

Review Process

  • Agoric team reviews your submitted work plan on Gitcoin.
  • It is best to join our Discord and post your gitcoin name in the bounties channel, so that we can follow up with you. Otherwise, we will write on your Gitcoin profile wall and say hello!
  • Agoric contacts you to provide reference projects / sample code for engineering review
  • Introductory call to discuss your plans and expected timeline
  • You join the Agoric Discord bounties channel (if you haven’t done so already)
  • Agoric accepts you on Gitcoin and you get started!

References

@danBamikiya
Copy link
Contributor

@cboydstun I have updated the extension and published it to the VSCode Markeplace. You can test it out now :)

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 4 weeks, 1 day from now.
Please review their action plans below:

1) bshevchenko has applied to start work (Funders only: approve worker | reject worker).

Ready to start with this one 😊

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 4 weeks from now.
Please review their action plans below:

1) danbamikiya has been approved to start work.

I have already updated the necessary files making sure the Agoric VSCode Extension installs the agoric sdk from the community-dev branch.
Related Commit

Learn more on the Gitcoin Issue Details page.

@danBamikiya
Copy link
Contributor

@cboydstun , 2 things from an "outsider":

  • please mark the targeted (or 'reserved') bounties as such (just on top of the issues "reserved for danBamikiya")

  • consider making the 3 vars configurable, thus users can override (e.g. using an own repo, some other branch, or even just directory)

    • sdkDirName
    • sdkRepo
    • sdkRepoBranch

@abebeos lovely suggestions! can you further expantiate on what you mean by "or even just directory" (which is the sdkDirName)?

the sdkDirName is folder name of the cloned repo https://github.com/Agoric/agoric-sdk/ (agoric-sdk). if a user uses their own repo (which I assume will be a fork) or a different branch, the folder name agoric-sdk will still be the same.

or do you mean the folder the sdk will be cloned into?

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 239.76 USD (240.00 USD @ $1.0/USD) attached to this issue has been cancelled by the bounty submitter

@danBamikiya
Copy link
Contributor

do you mean the folder the sdk will be cloned into?

yes, this would be

git clone -b $sdkRepoBranch $sdkRepo $sdkDirName

I assumed that making the branch/repo configurable would lead to some user asking for directory configuration, too (e.g. "agora-sdk-intra")

So, I'd say priority would be to have branch, then repo, and lastly directory configurable. If its too much of a problem, you could leave directory configuration out for now.

okay @abebeos I totally get what you mean now, that sdkDirName is also configurable, it was just not exposed to users. thanks for your lovely explanation and suggestions!

@cboydstun
Copy link
Author

@cboydstun , note that gitcoin seems to have a duplicate entry for the bounty:

Thanks @abebeos! I cancelled the duplicate. Maybe an impatient double click duplicated the entry? I know I didn't write it twice! 🤪

@janus
Copy link

janus commented Mar 3, 2023

@dckc Is this issue still open?

@dckc
Copy link
Member

dckc commented Mar 3, 2023

@jeetraut tells me it's done.

@dckc dckc closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

8 participants