Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orch docs have too much inline chaininfo #9992

Open
Tracked by #9757
dckc opened this issue Aug 29, 2024 · 2 comments · May be fixed by #10213
Open
Tracked by #9757

Orch docs have too much inline chaininfo #9992

dckc opened this issue Aug 29, 2024 · 2 comments · May be fixed by #10213
Assignees
@0xpatrickdev
Labels
documentation Improvements or additions to documentation

Comments

@dckc
Copy link
Member

dckc commented Aug 29, 2024 •
edited
Loading

API Docs for Interface Orchestrator have a huge amount of "known chains" info inlined in an awkward way:

image

cc @turadg
@dckc dckc mentioned this issue Aug 29, 2024
Open
@dckc dckc changed the title Orchestrator interface has too much inline chaininfo Orch docs have too much inline chaininfo Aug 29, 2024
@dckc dckc added the documentation Improvements or additions to documentation label Aug 29, 2024
@dckc
Copy link
Member Author

dckc commented Aug 29, 2024

While reviewing #9983 , this affects BrandInfo too:

image

cc @turadg

@turadg
Copy link
Member

turadg commented Aug 29, 2024

We just need to key by chainName string instead of the info.

@dckc dckc mentioned this issue Aug 29, 2024
Merged
@LuqiPan LuqiPan assigned 0xpatrickdev and unassigned LuqiPan Sep 23, 2024
@0xpatrickdev 0xpatrickdev linked a pull request Oct 3, 2024 that will close this issue
Open
This was referenced Dec 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xpatrickdev 0xpatrickdev

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types!: Chain takes KnownChainName generic parameter instead of ChainInfo Agoric/agoric-sdk
4 participants
@turadg @dckc @LuqiPan @0xpatrickdev