Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orchestration typedoc: portfolio holder #10217

Merged
merged 3 commits into from
Oct 4, 2024
Merged

orchestration typedoc: portfolio holder #10217

merged 3 commits into from
Oct 4, 2024

Conversation

0xpatrickdev
Copy link
Member

@0xpatrickdev 0xpatrickdev commented Oct 4, 2024 •
edited
Loading

refs: #9757

Description

  • export types for PortfolioHolder and CombinedInvitationMakers for use in typedoc
  • improve typedoc copy

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

This PR makes these exos appear in typedoc docs:

Testing Considerations

n/a

Upgrade Considerations

n/a

@0xpatrickdev 0xpatrickdev requested a review from a team as a code owner October 4, 2024 17:12
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 4, 2024

⚠️ The sha of the head commit of this PR conflicts with #10211. Mergify cannot evaluate rules on this PR. ⚠️

This was referenced Oct 4, 2024
Merged
Open
Base automatically changed from pc/deposit-withdraw-e2e to master October 4, 2024 17:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

@0xpatrickdev 0xpatrickdev force-pushed the pc/portfolio-holder-typedoc branch from 53f76a5 to 5863286 Compare October 4, 2024 18:05
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2024 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5863286
Status: ✅  Deploy successful!
Preview URL: https://e64728ad.agoric-sdk.pages.dev
Branch Preview URL: https://pc-portfolio-holder-typedoc.agoric-sdk.pages.dev

View logs

@0xpatrickdev 0xpatrickdev requested review from turadg and dckc October 4, 2024 18:47
@0xpatrickdev 0xpatrickdev added the automerge:rebase Automatically rebase updates, then merge label Oct 4, 2024
@mergify mergify bot merged commit edc7176 into master Oct 4, 2024
88 checks passed
@mergify mergify bot deleted the pc/portfolio-holder-typedoc branch October 4, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

@AgoricTriage AgoricTriage Awaiting requested review from AgoricTriage AgoricTriage is a code owner automatically assigned from Agoric/engprodexec

@dckc dckc Awaiting requested review from dckc

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xpatrickdev @turadg