Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve Marshal typing improvements from #1905 #1965

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Preserve Marshal typing improvements from #1905 #1965

merged 3 commits into from
Nov 3, 2020

Conversation

erights
Copy link
Member

@erights erights commented Nov 3, 2020

The #1905 spike is idle for now. But I wanted to make sure that these improvements to marshal and same-structure don't get lost.

@erights erights requested a review from michaelfig November 3, 2020 06:09
michaelfig
michaelfig approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes proposed. Feel free to merge when CI passes.

packages/marshal/package.json Show resolved Hide resolved
packages/marshal/src/marshal.js Show resolved Hide resolved
packages/marshal/src/types.js Outdated Show resolved Hide resolved
packages/same-structure/package.json Show resolved Hide resolved
@erights erights merged commit 4d8cab8 into master Nov 3, 2020
@erights erights deleted the marshal-types branch November 3, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @michaelfig