agorictest-6 deployment fixes #2493
Conversation
michaelfig
added
cosmic-swingset
| WORKDIR /usr/src/journalbeat | ||
| RUN apt-get update -y && apt-get install -y libsystemd-dev | ||
| RUN go get github.com/mheese/journalbeat | ||
| # FIXME: Journalbeat compilation is currently broken, but non-essential. |
There was a problem hiding this comment.
We eventually do want to use journalbeat? That's why the FIXME and the commented rather than deleted code?
There was a problem hiding this comment.
Ah, just paranoia. I'll delete the code.
| @@ -66,4 +66,4 @@ docker-push-solo: | |||
|
|
|||
| docker-push-deployment: | |||
| $(DONT_PUSH_LATEST) docker push agoric/deployment:latest | |||
| docker push $(REPOSITORY)-solo:$(TAG) | |||
There was a problem hiding this comment.
what did this used to do? how was it even close?
There was a problem hiding this comment.
Fortunately, the old code was never executed (instead the .github/workflows/docker.yml built and tagged the images). I ran into this only because journalbeat failed to compile in the Github action, and I needed to push the images manually.
Which upon inspection wasn't pushing the agoric/deployment tag as I expected. So I fixed it.
There was a problem hiding this comment.
It was introduced as part of a refactoring to fix a prior refactoring.
These are some minor fixes that would have helped deploy the latest testnet more smoothly. We remove the deprecated
journalbeatpart of the docker containers, and push the correctagoric/deployment:latesttag. We also ignore errors when creating transactions from thecosmos-delegates.txtfile.Aside from that, we move off of a custom cosmos-sdk (which was based on v0.41.0) to the official v0.41.1 release since cosmos/cosmos-sdk#8478 has been fixed and released.