fix(marshal): serialize empty objects as data, not pass-by-reference #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally change the serialization of a plain empty object, i.e. `harden({})`,
from a pass-by-reference "marker" to plain pass-by-copy data. We think we've
identified all the places where an empty object was used represent a marker,
and changed them to use `Far(iface, {})` instead, which triggers
pass-by-reference.
refs #2018
|
@michaelfig any idea what's making this test fail? I thought we'd caught all the empty-objects-as-handle that needed changing. The specific failure (https://github.com/Agoric/agoric-sdk/pull/2622/checks?check_run_id=2093138223#step:9:1558) is in |
|
Wait, weird, I re-ran the checks and the second time it didn't fail. I'm not sure what's going on. |
|
Ok, I think that was an artifact, the test looks like it might be timing sensitive, and the assertion was that the number of calls to the timer handler was 2 instead of 1, which sounds like timing. So I think this is ready for review. This flips the big #2018 switch, so review really means "are we ready to change the behavior of |
katelynsills
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally change the serialization of a plain empty object, i.e.
harden({}),from a pass-by-reference "marker" to plain pass-by-copy data. We think we've
identified all the places where an empty object was used represent a marker,
and changed them to use
Far(iface, {})instead, which triggerspass-by-reference.
refs #2018