fix: when trades for zero are requested don't throw #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought no one needed to request zero prices, and so I threw in that case. #4114 reveals a situation where it will happen in ordinary circumstances. Change the AMM code to respond with an empty amount when an empty amount is offered, and vice versa.
Chris-Hibbert
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4114
Description
I thought no one needed to request zero prices, and so I threw in that
case. #4114 reveals a
situation where it will happen in ordinary circumstances.
Change the AMM code to respond with an empty amount when an empty
amount is offered, and vice versa.
Security Considerations
None
Documentation Considerations
None
Testing Considerations
Updated tests.