Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(vaultFactory): refactor to macro #5900

Merged
merged 2 commits into from
Sep 2, 2022
Merged

test(vaultFactory): refactor to macro #5900

merged 2 commits into from
Sep 2, 2022

Conversation

turadg
Copy link
Member

@turadg turadg commented Aug 5, 2022

Description

Refactor some inter-protocol tests to use Ava macros

Note that the test.macro introduced in Ava 4 breaks under prepare-test-env-ava until endojs/endo#1235.

Also bumps the peerDependency in swingset-vat.

Security Considerations

--

Documentation Considerations

--

Testing Considerations

--

@turadg turadg requested a review from erights August 5, 2022 16:53
@turadg turadg marked this pull request as draft August 5, 2022 17:50
@turadg
Copy link
Member Author

turadg commented Aug 5, 2022

Converted to draft because https://github.com/Agoric/agoric-sdk/runs/7695661772?check_suite_focus=true failed on,

Run cd packages/zoe && yarn test:swingset
  cd packages/zoe && yarn test:swingset
  shell: /usr/bin/bash -e {0}
  env:
    ESM_DISABLE_CACHE: true
yarn run v1.[2](https://github.com/Agoric/agoric-sdk/runs/7695661772?check_suite_focus=true#step:5:2)2.19
$ ava 'test/swingsetTests/**/test-*.js' -T 10m --verbose

  Uncaught exception in test/swingsetTests/makeKind/test-makeKind.js

  ReferenceError: gc is not defined
    at evalmachine.<anonymous>:1:1
    at Script.runInContext (vm.js:144:12)
    at Script.runInNewContext (vm.js:149:17)
    at Object.runInNewContext (vm.js:[3](https://github.com/Agoric/agoric-sdk/runs/7695661772?check_suite_focus=true#step:5:3)03:38)
    at packages/SwingSet/src/lib-nodejs/engine-gc.js:9:1[5](https://github.com/Agoric/agoric-sdk/runs/7695661772?check_suite_focus=true#step:5:5)

  › evalmachine.<anonymous>:1:1
  › packages/SwingSet/src/lib-nodejs/engine-gc.js:[9](https://github.com/Agoric/agoric-sdk/runs/7695661772?check_suite_focus=true#step:5:10):[15](https://github.com/Agoric/agoric-sdk/runs/7695661772?check_suite_focus=true#step:5:16)

probably needs workersDisabled

Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @turadg I don't have time to absorb this adequately to approve before leaving town, but nothing seemed wrong. I suggest you elect another reviewer. Thanks.

@@ -1,50 +1,57 @@
// @ts-check
// Must be first to set up globals
import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';
import '@endo/init/debug.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add TODO comment to switch back to ses-ava once endojs/endo#1235 is fixed. (I see you already include the need to fix ava macros in the issue, thanks)

@erights erights self-requested a review August 10, 2022 22:33
@turadg turadg marked this pull request as ready for review August 11, 2022 14:36
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Aug 11, 2022
@turadg turadg changed the title demo Ava macro test(vaultFactory): refactor to macro Aug 15, 2022
@turadg turadg requested a review from Chris-Hibbert August 26, 2022 21:12
@turadg turadg added the bypass:integration Prevent integration tests from running on PR label Sep 2, 2022
@mergify mergify bot merged commit 4169ad0 into master Sep 2, 2022
@mergify mergify bot deleted the ta/ava-4-cleanup branch September 2, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants