-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(vaultFactory): refactor to macro #5900
Conversation
Converted to draft because https://github.com/Agoric/agoric-sdk/runs/7695661772?check_suite_focus=true failed on,
probably needs workersDisabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @turadg I don't have time to absorb this adequately to approve before leaving town, but nothing seemed wrong. I suggest you elect another reviewer. Thanks.
@@ -1,50 +1,57 @@ | |||
// @ts-check | |||
// Must be first to set up globals | |||
import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js'; | |||
import '@endo/init/debug.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add TODO comment to switch back to ses-ava once endojs/endo#1235 is fixed. (I see you already include the need to fix ava macros in the issue, thanks)
f8f122a
to
370b80c
Compare
370b80c
to
1c54260
Compare
1c54260
to
979b11a
Compare
979b11a
to
77996e9
Compare
Description
Refactor some inter-protocol tests to use Ava macros
Note that the
test.macro
introduced in Ava 4 breaks underprepare-test-env-ava
until endojs/endo#1235.Also bumps the
peerDependency
in swingset-vat.Security Considerations
--
Documentation Considerations
--
Testing Considerations
--