-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic swingset upgrade actions #8287
Conversation
Best reviewed commit-by-commit and white space hidden |
I'll have a look at this tomorrow. When you're up-and-about, can you PTAL at https://github.com/Agoric/agoric-sdk/actions/runs/6032610362/job/16368096857?pr=8287#step:5:25 ?
|
Yeah I missed an update to synthetic blocking sends created by simchain. The real chain will have params on the bootstrap block, so the sim chain should too. |
0f63e41
to
6330963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for sorting out the prioritization that I balked at. :)
2c3d6c5
to
b1e98d2
Compare
…gset-upgrade-plan Atomic swingset upgrade actions
…gset-upgrade-plan Atomic swingset upgrade actions
…gset-upgrade-plan Atomic swingset upgrade actions
…gset-upgrade-plan Atomic swingset upgrade actions
…gset-upgrade-plan Atomic swingset upgrade actions
…gset-upgrade-plan Atomic swingset upgrade actions
…gset-upgrade-plan Atomic swingset upgrade actions
closes: #8279
Description
Builds on #8112 to run the core proposals part of an upgrade to completion within the upgrade block.
Security Considerations
With an infinite meter, there is a risk that a buggy core proposal or the remaining Swingset work executed before may never run to completion and effectively stall the chain.
Scaling Considerations
This will cause all upgrade work to happen in the upgrade block, which may take arbitrarily long.
Documentation Considerations
None
Testing Considerations
Updated the docker test to verify the network vat is available as soon as the pre test starts, however the docker test infra does not make it possible to test this immediately once the upgrade block is committed, so really it's a best effort.
Upgrade Considerations
Yes