ci: use a manual check for integration-test-result #8315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/manual-integration-check
branch
from
efaef35 to
2e27edf
Compare
michaelfig
approved these changes
Sep 8, 2023
mhofman
added a commit
that referenced
this pull request
Jan 12, 2024
* ci: use a manual check for integration-test-result * chore: recreate integration-test-result check on re-run
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Mar 4, 2024
* ci: use a manual check for integration-test-result * chore: recreate integration-test-result check on re-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the
integration-test-resultcheck to a check created and managed through the GitHub API to solve the constant problems with mergify based merges.This change causes a queued
integration-test-resultcheck to be created as soon as the labels change, which will allow mergify to find this check when it evaluates its rules instead of a potentially missing or outdate one.Then the integration test is updated to find and update the status of this check. This includes some bug fixes to make sure a runner fail (reported as a skipped job) causes the status to be reported as failed. The status check is reported while not tripping up the "previous successful run" checks
Security Considerations
None
Scaling Considerations
This does not revert the cancel of concurrent job, we can revisit later
Documentation Considerations
No new documentation
Testing Considerations
Heavily iterated upon in a new repo setup to replicate agoric-sdk's mergify setup: Agoric/mergify-experiements#2
Feel free to play with labels in this PR too.
Upgrade Considerations
None