Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix bench config #8352

Merged
merged 1 commit into from
Sep 19, 2023
Merged

test: fix bench config #8352

merged 1 commit into from
Sep 19, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 19, 2023

Description

#8313 changed supports module to .ts. That broke the benchmark job. It was permitted by CI because the benchmark job isn't required.

This gives the benchmark's Ava config the options that are now needed

Security Considerations

n/a, test

Scaling Considerations

n/a, test

Documentation Considerations

none

Testing Considerations

fixes it

Upgrade Considerations

n/a, test

@turadg turadg requested a review from FUDCo September 19, 2023 02:34
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit.

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Sep 19, 2023
#8313 changed supports module to .ts
@mergify mergify bot merged commit 3f47cf0 into master Sep 19, 2023
71 checks passed
@mergify mergify bot deleted the ta/benchmark-ts branch September 19, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants