fix(agops): fix continuing id lookup in oracle setPrice

[dckc]

needs instance based on --pair

closes: #8281
refs: #XXXX

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

• IOU a test

Upgrade Considerations

[dckc]

cc @0xpatrickdev

[dckc]

I looked into doing a test. Threading IO capabilities explicitly looks like more trouble than it's worth (#2160).

How about landing this as is?

[turadg]

Threading IO capabilities explicitly looks like more trouble than it's worth.

It would be fine to use ambient IO capabilities for a test.

I looked into doing a test.

A test would be nice but since this is an internal tool, if you've tested it manually that suffices for me.

[dckc]

It would be fine to use ambient IO capabilities for a test.

Hm. It would go out to the network and such then, right? I would need to run a blockchain node or something.
The idea was to mock what it would find out in the world.

Alternatively, I could factor out the part that I fixed and unit test that, but again, it's kind of a pain.

[turadg]

The idea was to mock what it would find out in the world.

Yeah, I was assuming we could mock module imports. That's built into Jest. In Ava it would take something like https://github.com/iambumblehead/esmock

[dckc]

... mock module imports ...

Yeah, that's another approach. I didn't look into it. Does it make a test seem more cost-effective?

[turadg]

More but not enough imo. Also using esmock-loader precludes using tsx-loader.