Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): upgrade TypeScript to 5.3 #8571

Merged
merged 1 commit into from
Nov 29, 2023
Merged

chore(types): upgrade TypeScript to 5.3 #8571

merged 1 commit into from
Nov 29, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 28, 2023

Description

Update TypeScript from 5.2 to 5.3

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

CI

Upgrade Considerations

n/a

@turadg turadg requested review from dckc and iomekam November 28, 2023 19:14
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know why the ci bot is so unhappy before approving.

I wondered what prompted this, but now I remember discussion of typedoc stuff a la #8343 / #4291 .

@turadg
Copy link
Member Author

turadg commented Nov 28, 2023

I'd like to know why the ci bot is so unhappy before approving.

I had manually edited the yarn.lock to get rid of what appeared to be a stale dep on 5.2.2, but it turns out that Endo's eslint plugin is pretty specific about the TS version:

"@endo/eslint-plugin@^0.5.1":
  version "0.5.2"
  resolved "https://registry.yarnpkg.com/@endo/eslint-plugin/-/eslint-plugin-0.5.2.tgz#835d22e9ff17d9935f7f565e50a21ef07aa92ca2"
  integrity sha512-WzQmzBXoGGm5vb2mX/Ho9dS5wSaajmeE2PnFqiBUwPQ5ml7B0T7/QwzV5MSAv1ClyzDt3t5j36ENWxeibb2C9Q==
  dependencies:
    "@typescript-eslint/utils" "^6.6.0"
    requireindex "~1.1.0"
    tsutils "~3.21.0"
    typescript "~5.2.2"

@dckc
Copy link
Member

dckc commented Nov 28, 2023

... but it turns out that Endo's eslint plugin is pretty specific about the TS version:

"@endo/eslint-plugin@^0.5.1":
...
  dependencies:
...
    typescript "~5.2.2"

So we'll have both 5.2.2 and 5.3 for a while? That seems worth tracking in an issue. Do you know if we already have something close?

@turadg
Copy link
Member Author

turadg commented Nov 28, 2023

So we'll have both 5.2.2 and 5.3 for a while?

A dev dependency of this repo has a dependency on an earlier version. That's pretty normal, imo. Eventually Endo will update its deps. In the meantime, there's no harm.

@turadg turadg requested a review from dckc November 29, 2023 21:07
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Nov 29, 2023
@mergify mergify bot merged commit 76118c5 into master Nov 29, 2023
77 checks passed
@mergify mergify bot deleted the typescript-5.3 branch November 29, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants