feat(cosmos): un-wire x/crisis #8582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimLarson
approved these changes
Dec 6, 2023
| @@ -236,7 +236,6 @@ export function finishCosmosGenesis({ genesisJson, exportedGenesisJson }) { | |||
|
|
|||
| // Set the denomination for different modules. | |||
| genesis.app_state.mint.params.mint_denom = MINT_DENOM; | |||
| genesis.app_state.crisis.constant_fee.denom = MINT_DENOM; | |||
There was a problem hiding this comment.
Does this run afoul of requiring a bundle update?
There was a problem hiding this comment.
Nope, the CLI does not impact bundles. Because of cycles in our dependency graph it will cause a version bump of some dependencies, but other PRs will do that too.
mhofman
added a commit
that referenced
this pull request
Dec 6, 2023
* feat(cosmos): un-wire x/crisis * fixup! feat(cosmos): un-wire x/crisis --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Dec 6, 2023
* feat(cosmos): un-wire x/crisis * fixup! feat(cosmos): un-wire x/crisis --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
added a commit
that referenced
this pull request
Dec 6, 2023
* feat(cosmos): un-wire x/crisis * fixup! feat(cosmos): un-wire x/crisis --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8581
Description
Remove the
x/crisismodule, as it is not functioning as designed.This is effectively applying the changes from
https://github.com/cosmos/cosmos-sdk/pull/18380to our app.Security Considerations
Addresses GHSA-qfc5-6r3j-jj22 and GHSA-w5w5-2882-47pc
Scaling Considerations
None
Documentation Considerations
TBD
Testing Considerations
I have manually verify that a
MsgVerifyInvariantdoes not execute, it fails with a parse error.I did not add to an upgrade test as it would have required some contortions to generate the message manually (or before the upgrade), and sign and broadcast it separately.
Upgrade Considerations
I added code to plumb the removal of the module in the store loader on upgrade. Requires a chain software upgrade.