Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to unreleased docker tag #8760

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Default to unreleased docker tag #8760

merged 2 commits into from
Jan 17, 2024

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Jan 17, 2024

Description

While reviewing #8743 we realized that the reliance on the latest docker image could be confusing, as it is actually expecting a locally built image of the sdk, not the latest released version of the sdk.

This removes some no longer used docker push logic from the deployment makefile, and uses an unreleased tag by default when building locally, which is in turn used as the image tag by the a3p integration test

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

Maybe?

Testing Considerations

Relying on existing CI to catch any breakage

Upgrade Considerations

None

@mhofman mhofman requested review from turadg and gibson042 January 17, 2024 17:05
Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mhofman mhofman added the automerge:rebase Automatically rebase updates, then merge label Jan 17, 2024
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thought to use unreleased instead of local, as there can be local builds of released versions.

And thanks for the related cleanup

@mhofman
Copy link
Member Author

mhofman commented Jan 17, 2024

Good thought to use unreleased instead of local, as there can be local builds of released versions.

Credit goes to @michaelfig who suggested it!

@mergify mergify bot merged commit f85d35b into master Jan 17, 2024
74 checks passed
@mergify mergify bot deleted the mhofman/clean-docker-tags branch January 17, 2024 17:46
mhofman pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants