test: use ses-ava #9026
test: use ses-ava #9026
Conversation
erights
force-pushed
the
markm-use-ses-ava
branch
from
947b30b to
faf4656
Compare
| @@ -0,0 +1,7 @@ | |||
| import '@endo/init/debug.js'; | |||
There was a problem hiding this comment.
I don't see any reason for upgrade tests to run under lockdown. They're scripting the chain which is fully locked down. Please leave these as is so we don't have this extra boilerplate to write the tests.
| // eslint-disable-next-line import/order | ||
| import { test } from '../tools/prepare-test-env-ava.js'; |
There was a problem hiding this comment.
please avoid introducing a lint suppression.
There was a problem hiding this comment.
Aside from fixing endojs/endo#1467 , how? See previous discussion at endojs/endo#1439 (comment)
There was a problem hiding this comment.
Yes, that seems to be the only way. Out of scope, I suppose.
At the least please use // eslint-disable-line so that reordering imports doesn't break the association of the comment with the line. Also would be good to indicate this is not to be emulated by linking to the issue.
| // eslint-disable-next-line import/order | |
| import { test } from '../tools/prepare-test-env-ava.js'; | |
| import { test } from '../tools/prepare-test-env-ava.js'; // eslint-disable-line import/order -- https://github.com/endojs/endo/issues/1467 |
| @@ -0,0 +1,7 @@ | |||
| import '@endo/init/debug.js'; | |||
There was a problem hiding this comment.
why does this file need to be repeated in every package?
Shouldn't @endo/ses-ava take care of this? E.g. in a test you can simply import,
import test from '@endo/ses-ava';This is how Ava works. I don't see why ses-ava needs to work so differently.
closes: #XXXX
refs: endojs/endo#2109
Description
Switch many uses of raw
avato use@endo/ses-avainstead. Done in anticipation of endojs/endo#2109 , which will make the ses-ava experience more pleasant. But not dependent on it, and should work now. Note the absence of an#-endo-branchat the top of this PR comment.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
once synced with an endo that includes endojs/endo#2109 , will make for a more pleasant testing and debugging experience.
Upgrade Considerations
none