From b9c90aab86729e515499997458d4542e3152efd1 Mon Sep 17 00:00:00 2001
From: Siarhei Liakh <siarhei@agoric.com>
Date: Tue, 27 Aug 2024 15:36:11 +0000
Subject: [PATCH] chore (packages): Fix remaining lint issues (#9632)

closes: #3632
refs: #9965

Fixed the following two issues:

1. packages/inter-protocol/src/proposals/startPSM.js
  351:1  warning  Expected JSDoc block to be aligned  jsdoc/check-alignment
- factored out typedef from the type cast so the cast is now a
  single-line comment.

2. packages/agoric-cli/test/inter-cli.test.js
  255:1  warning  `test.todo()` should not be used  ava/no-todo-test
  361:1  warning  `test.todo()` should not be used  ava/no-todo-test
  419:1  warning  `test.todo()` should not be used  ava/no-todo-test
  610:1  warning  `test.todo()` should not be used  ava/no-todo-test
  620:1  warning  `test.todo()` should not be used  ava/no-todo-test
  622:1  warning  `test.todo()` should not be used  ava/no-todo-test
  628:1  warning  `test.todo()` should not be used  ava/no-todo-test
- Opened a new issue #9965 to create missing tests and removed test.todo()
---
 packages/agoric-cli/test/inter-cli.test.js    | 11 +--------
 .../inter-protocol/src/proposals/startPSM.js  | 24 +++++++++++--------
 2 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/packages/agoric-cli/test/inter-cli.test.js b/packages/agoric-cli/test/inter-cli.test.js
index 3a80a27c26d..cddbe85fb07 100644
--- a/packages/agoric-cli/test/inter-cli.test.js
+++ b/packages/agoric-cli/test/inter-cli.test.js
@@ -252,8 +252,6 @@ test('amount parsing', t => {
   });
 });
 
-test.todo('want as max collateral wanted');
-
 /**
  * @type {import('@agoric/smart-wallet/src/offers.js').OfferStatus &
  *         { offerArgs: import('@agoric/inter-protocol/src/auction/auctionBook.js').OfferSpec}}
@@ -358,8 +356,6 @@ test('diagnostic for agd ENOENT', async t => {
   t.is(out.join('').trim(), '');
 });
 
-test.todo('agd ENOENT clue outside normalizeAddress');
-
 const usageTest = (words, blurb = 'Command usage:') => {
   test(`Usage: ${words}`, async t => {
     const argv = `node agops ${words} --help`.split(' ');
@@ -416,7 +412,6 @@ test('formatBid', t => {
   }
 });
 
-test.todo('fmtBid with error does not show result');
 /*
 _not_ like this:
 
@@ -607,7 +602,6 @@ test('README ex1: inter bid place by-price: printed offer is correct', async t =
   t.deepEqual(txt, expected);
 });
 
-test.todo('inter bid by-price shows tx, wallet status');
 /*
 $ agops inter bid by-price --price 0.81 --give 0.5 --maxBuy 3 --from gov2
 2023-03-30T21:48:14.479332418Z not in block 49618 retrying...
@@ -617,12 +611,9 @@ first bid update:
 {"id":"bid-1680212903989","price":"0.81 IST/ATOM","give":{"Bid":"0.5IST"},"want":"3ATOM","result":"Your bid has been accepted"}
 */
 
-test.todo('execSwingsetTransaction returns non-0 code');
-
-test.todo('already cancelled bid');
 /*
 $ agops inter bid cancel --from gov2 bid-1680211556497
 bid-1680211556497 not in live offer ids: bid-1680211593489,bid-1680212903989,bid-1680213097499,bid-1680220217218,bid-1680220368714,bid-1680220406939
 */
 
-test.todo('--give without number');
+// TODO improve test coverage https://github.com/Agoric/agoric-sdk/issues/9965
diff --git a/packages/inter-protocol/src/proposals/startPSM.js b/packages/inter-protocol/src/proposals/startPSM.js
index 8a6e0bd5daa..9c00cdcf9d9 100644
--- a/packages/inter-protocol/src/proposals/startPSM.js
+++ b/packages/inter-protocol/src/proposals/startPSM.js
@@ -347,18 +347,22 @@ export const makeAnchorAsset = async (
     }),
   );
 
-  const { creatorFacet: mint, publicFacet: issuer } = /**
-   * @type {{
+  /**
+   * @typedef {{
    *   creatorFacet: ERef<Mint<'nat'>>;
    *   publicFacet: ERef<Issuer<'nat'>>;
-   * }}
-   */ (
-    await E(startUpgradable)({
-      installation: mintHolder,
-      label: keyword,
-      terms,
-    })
-  );
+   * }} PsmKit
+   */
+
+  const { creatorFacet: mint, publicFacet: issuer } =
+    /** @type {PsmKit} */
+    (
+      await E(startUpgradable)({
+        installation: mintHolder,
+        label: keyword,
+        terms,
+      })
+    );
 
   const brand = await E(issuer).getBrand();
   const kit = harden({ mint, issuer, brand });