feat: Improve the jump-to-fragment fixup for non-heading targets #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Nov 30, 2023
| return () => window.removeEventListener(type, stopPropagation, true); | ||
| }); | ||
| const passEvents = () => { | ||
| while (restorers.length > 0) restorers.pop()(); |
There was a problem hiding this comment.
Any reasons for restorers.pop() instead of restorers.shift()? Maybe add a comment as to why, or why it doesn't matter.
Router logic was swallowing history entries and not scrolling far enough for such targets to clear the fixed header.
gibson042
force-pushed
the
gibson-2023-11-scroll-to-non-toc-target
branch
from
45cbb4a to
23efb75
Compare
Deploying with
|
| Latest commit: |
23efb75
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f65cad36.documentation-7tp.pages.dev |
| Branch Preview URL: | https://gibson-2023-11-scroll-to-non.documentation-7tp.pages.dev |
10 tasks
0xpatrickdev
added a commit
that referenced
this pull request
Mar 14, 2024
- removes code added in #882 that aimed to fix anchor tag linking on initial page loads as it no longer seems necessary with vitepress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router logic was swallowing history entries and not scrolling far enough for such targets1 to clear the fixed header.
Footnotes
which do not currently exist but are being added, cf. https://github.com/Agoric/documentation/pull/876#discussion_r1409657230 ↩