Timeline of loadgen stats #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Nov 25, 2021
mhofman
commented
Nov 25, 2021
mhofman
force-pushed
the
mhofman/report-stage-results
branch
from
194b9cd to
a2e2263
Compare
mhofman
force-pushed
the
mhofman/runner-compat-fixes
branch
2 times, most recently
from
b2b3005 to
dbf3f59
Compare
mhofman
changed the base branch from
mhofman/runner-compat-fixes
to
mhofman/runner-testnet-compat
mhofman
force-pushed
the
mhofman/report-stage-results
branch
from
a2e2263 to
9c0e3bd
Compare
mhofman
force-pushed
the
mhofman/runner-testnet-compat
branch
from
4961771 to
afdc022
Compare
mhofman
force-pushed
the
mhofman/report-stage-results
branch
from
9c0e3bd to
2541e2f
Compare
mhofman
force-pushed
the
mhofman/runner-testnet-compat
branch
from
58cd8be to
ceb913f
Compare
mhofman
force-pushed
the
mhofman/report-stage-results
branch
from
2541e2f to
8717013
Compare
|
@michaelfig since your initial review I addressed your feedback and added d30dea3 and 8717013. Since those are minor changes, and @warner approved the PR following them, I will squash the feedback commits, and merge. |
mhofman
force-pushed
the
mhofman/report-stage-results
branch
from
8717013 to
bfe276b
Compare
Reorder CSV stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the plumbing to generate a CSV file containing a small subset of the loadgen stats across multiple revisions.
The file is currently generated locally and manually imported into a google spreadsheet. I still want to figure out a better way, by uploading the results automatically somewhere, and make them available to a hosted dashboard, possibly through a "revision completion" hook for the background script.
I generated a preliminary corpus of data on my own machine, with the results available here, using the following config:
--no-stage.save-storage --monitor-interval=1 --stage.duration=10 --stage.loadgen.vault.interval=30 --stage.loadgen.amm.interval=30 --stage.loadgen.amm.wait=15 --stage.loadgen.vault.limit=2 --stage.loadgen.amm.limit=2A longer version is currently being generated on the benchmark machine for the same revisions with the following config:
--no-stage.save-storage --monitor-interval=1 --stage.duration=30 --stage.loadgen.vault.interval=60 --stage.loadgen.amm.interval=60 --stage.loadgen.amm.wait=30I'd ultimately like to run the default 24h test in the background on a subset of past revisions to backfill the data, but I'm not sure which revisions would be the best candidates yet.
Stack on top of compatibility fixes (#37 / #44) and stats work (#36).
As always, best reviewed commit-by-commit.