Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p95 to stats summaries #46

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Add p95 to stats summaries #46

merged 4 commits into from
Feb 4, 2022

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Jan 20, 2022

As requested by @Tartuffo, this change refactors the stats summary generation and adds p95 percentiles to the values for which we generated averages.

I've also added a script which parses a perf.jsonl stream and rewrites the stats, regenerating the summaries. This helped me verify that the new summary logic didn't result in any real changes (just a few differences due to rounding).

for i in manual-*
do 
  echo $i
  diff \
    <(tail -q -n 1 $i/perf.jsonl | jq '.stats') \
    <(cat $i/perf.jsonl | ../runner/bin/regen-perf.js | tail -q -n 1 | jq '.stats')
done

I also fixed a bug where the stage stats summaries were not generated for a failing stage.

Related to: 5d4034a in #36

@mhofman mhofman requested a review from warner January 20, 2022 02:58
@Tartuffo
Copy link

Thanks, @mhofman !

@mhofman mhofman force-pushed the mhofman/add-percentile branch 2 times, most recently from ac12963 to b5822ff Compare January 20, 2022 18:08
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@mhofman mhofman force-pushed the mhofman/add-percentile branch from b5822ff to 1ca055b Compare February 2, 2022 05:33
@mhofman mhofman merged commit 8ae7ae0 into main Feb 4, 2022
@mhofman mhofman deleted the mhofman/add-percentile branch February 5, 2022 02:24
@mhofman mhofman linked an issue Feb 26, 2022 that may be closed by this pull request
@mhofman mhofman mentioned this pull request Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add percentile to stats
3 participants