Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @Tartuffo, this change refactors the stats summary generation and adds p95 percentiles to the values for which we generated averages.
I've also added a script which parses a
perf.jsonl
stream and rewrites the stats, regenerating the summaries. This helped me verify that the new summary logic didn't result in any real changes (just a few differences due to rounding).I also fixed a bug where the stage stats summaries were not generated for a failing stage.
Related to: 5d4034a in #36