Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long list for identity #18

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

elizabethengelman
Copy link

@elizabethengelman elizabethengelman commented Nov 22, 2023

What

Adding a --long flag to soroban identity ls, similar to soroban network ls --long to print out the paths to identity configuration files.

Why

This was originally added in a previous PR (stellar#743) and was removed at some point - presumably unintentionally. This seems like a helpful addition to help users understand where their identities are being configured.

Example output:

$ soroban identity ls -l
/Users/elizabethengelman/.config/soroban/identity/alice.toml
Name: alice

/Users/elizabethengelman/.config/soroban/identity/bob.toml
Name: bob

/Users/elizabethengelman/.config/soroban/identity/carol.toml
Name: carol

Known limitations
N/A

Copy link

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@willemneal willemneal merged commit 3349f04 into feat!/refactor-config Nov 22, 2023
15 of 22 checks passed
willemneal pushed a commit that referenced this pull request Nov 25, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Nov 28, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Nov 29, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Dec 7, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Dec 8, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Dec 11, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Dec 13, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Dec 15, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Dec 15, 2023
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Jan 3, 2024
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Jan 9, 2024
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
willemneal pushed a commit that referenced this pull request Jan 11, 2024
* Add list_identities_long in config/locator.rs

* Add a long ls option to config identity command

* Add -l to docs
@elizabethengelman elizabethengelman deleted the add-long-list-for-identity branch February 26, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants