Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosid): add friendly ID generator support #724

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

Ahoo-Wang
Copy link
Owner

  • Implement FriendlyCosIdGenerator and FriendlyIdStateParser
  • Update CosIdGeneratorProperties to include new friendly ID options
  • Add tests for friendly ID generator functionality
  • Update documentation to reflect new friendly ID generator type

- Implement FriendlyCosIdGenerator and FriendlyIdStateParser
- Update CosIdGeneratorProperties to include new friendly ID options
- Add tests for friendly ID generator functionality
- Update documentation to reflect new friendly ID generator type
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (1368f23) to head (19e6c25).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...starter/cosid/CosIdGeneratorAutoConfiguration.java 62.50% 3 Missing ⚠️
...ava/me/ahoo/cosid/cosid/FriendlyIdStateParser.java 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #724      +/-   ##
============================================
+ Coverage     84.70%   84.83%   +0.13%     
- Complexity     1291     1306      +15     
============================================
  Files           210      212       +2     
  Lines          4165     4215      +50     
  Branches        421      422       +1     
============================================
+ Hits           3528     3576      +48     
- Misses          355      357       +2     
  Partials        282      282              
Flag Coverage Δ
unittests 84.83% <91.07%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ahoo-Wang Ahoo-Wang merged commit 21db41e into main Feb 14, 2025
43 checks passed
@Ahoo-Wang Ahoo-Wang deleted the FriendlyId branch February 14, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant